From fa748f3e1c0b0571e2c53514a55794ca16d90b18 Mon Sep 17 00:00:00 2001 From: Danny Holman Date: Fri, 16 Feb 2024 12:35:04 -0600 Subject: arch: i386: kernel: the serial driver should be more POSIX-y Make the serial driver behave more like a standard POSIX call. It should have write and read functions that call architecture specific functions. Signed-off-by: Danny Holman --- arch/i386/kernel/serial.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) (limited to 'arch/i386/kernel') diff --git a/arch/i386/kernel/serial.c b/arch/i386/kernel/serial.c index 5bd4105..25a01fe 100644 --- a/arch/i386/kernel/serial.c +++ b/arch/i386/kernel/serial.c @@ -5,6 +5,14 @@ #define PORT 0x3f8 +static inline int _serial_received(void) { + return inb(PORT + 5) & 1; +} + +static inline int _is_transmit_empty(void) { + return inb(PORT + 5) & 0x20; +} + int serial_init(void) { outb(PORT + 1, 0x00); outb(PORT + 3, 0x80); @@ -23,20 +31,12 @@ int serial_init(void) { return 0; } -int serial_recieved(void) { - return inb(PORT + 5) & 1; +void serial_putchar(char c) { + while (_is_transmit_empty() == 0); + outb(PORT, c); } -char read_serial(void) { - while (serial_recieved() == 0); +char serial_getchar(void) { + while (_serial_received() == 0); return inb(PORT); } - -int is_transmit_empty(void) { - return inb(PORT + 5) & 0x20; -} - -void write_serial(char a) { - while (is_transmit_empty() == 0); - outb(PORT, a); -} -- cgit v1.2.3