diff options
| author | Danny Holman <dholman@gymli.xyz> | 2021-01-20 22:40:40 -0600 |
|---|---|---|
| committer | Danny Holman <dholman@gymli.xyz> | 2021-01-20 22:40:40 -0600 |
| commit | 3898c79cb27f21bc552a341d3d8c26af52263257 (patch) | |
| tree | 08e5371a2aa28772afd1bc1b88e54eb284badfa5 | |
| parent | 7a6cf86e4dd3094ed5aa41bf76d93c28c89e85e7 (diff) | |
serial: don't declare serial_init as static
The function serial_init should not be declared as static. This function
could change under a different architecture and should be defined with
the target architecture.
Signed-off-by: Danny Holman <dholman@gymli.xyz>
| -rw-r--r-- | arch/i386/serial.c | 2 | ||||
| -rw-r--r-- | include/kernel/serial.h | 2 | ||||
| -rw-r--r-- | kernel/init.c | 1 |
3 files changed, 3 insertions, 2 deletions
diff --git a/arch/i386/serial.c b/arch/i386/serial.c index b172e82..c1266bb 100644 --- a/arch/i386/serial.c +++ b/arch/i386/serial.c @@ -3,7 +3,7 @@ #define PORT 0x3f8 -static int serial_init(void) { +int serial_init(void) { outb(PORT + 1, 0x00); outb(PORT + 3, 0x80); outb(PORT + 0, 0x03); diff --git a/include/kernel/serial.h b/include/kernel/serial.h index a3a54b0..79d856b 100644 --- a/include/kernel/serial.h +++ b/include/kernel/serial.h @@ -1,7 +1,7 @@ #ifndef SERIAL_H #define SERIAL_H -static int serial_init(void); +int serial_init(void); char read_serial(void); void write_serial(char a); diff --git a/kernel/init.c b/kernel/init.c index ed6d1a7..b808122 100644 --- a/kernel/init.c +++ b/kernel/init.c @@ -1,5 +1,6 @@ #include <kernel/tty.h> #include <kernel/io.h> +#include <kernel/serial.h> void kernel_main(void) { tty_init(); |